Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Navigating through the event pages should persist location to URL #1281

Open
caesay opened this issue Apr 4, 2017 · 3 comments
Open

Navigating through the event pages should persist location to URL #1281

caesay opened this issue Apr 4, 2017 · 3 comments

Comments

@caesay
Copy link
Contributor

caesay commented Apr 4, 2017

This sits on the back of #1280, once that is complete we can look at this:

The current view of events should be entirely represented in the URL (search string, page number, anchor element etc). The reason why this is important / useful is being able to send a link to a colleague and have them be looking at the same page as you instead of needing to walk them through the search string, links to click, page number to be on, etc.

@niemyjski
Copy link
Member

Yeah, I really want this ability too. It's really tough to implement this right now because everything is a component and some dashboards have two lists on it. What do you know what page goes to which component? I guess our component could have a paging prefix (might be a simple fix). That might make this easy to implement.

@caesay
Copy link
Contributor Author

caesay commented Apr 6, 2017

I don't know about any challenges that are angular specific, but identifying what url param goes to what component shouldn't be a big pain. As far as I know we only have a "Frequent" feed and a "Recent" feed, right? so we just need to prefix between the two like you say.

@niemyjski
Copy link
Member

"Most views in the UI allow 20 items per page, and you get to cycle between pages. A frequent use case for me is to look at all my sessions, and then drill into a session to see the events. If I move beyond page 1 of my session events, drill into a session, and then press the browser back button to return to the list... I'm returned to page 1, not the page I was just on. This makes drilling into details very cumbersome for any events not listed on the first page." @boydpatterson

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

No branches or pull requests

2 participants