-
-
Notifications
You must be signed in to change notification settings - Fork 517
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
"User Name" uses identity instead of name from SetUserIdentity #84
Comments
Yes, The first parameter can be any unique identifier (email address, user id in your system etc..) the second parameter is a friendly name that describes the user (Full Name, System A User)... I don't think we are showing the friendly name in the UI are we? |
What do you think it should say? |
User Identity |
Yeah I agree. Is there any chance you can do a pull request for this ( https://github.com/exceptionless/Exceptionless.UI/blob/master/src/app/event/tabs/overview.tpl.html#L86-L89 ) as well as add a check to see if friendly name is specified and show that as well? I'm thinking maybe friendly name is called User Name and then we have User Identity above it with the identity. |
I will give it a go, if I can get a local instance of Exceptionless running. |
Nice find can you please create a new issue for that. It's because we assume 7zip is installed. As a temp workaround can you install 7zip. |
I had 7-Zip installed but my installation did not set the PATH Environmental variable. Requirements:
|
I have tried to fix this, but I have not been able to get the Exceptionless.UI project running, so I'm not sure if it works. |
Thanks for posting the screenshots. We have some work to do on the setup docs and will create a new virtual machine to see the exact steps and prereqs needed. You shouldn't need git for any of this (I thought npm just used http). Where you able to get this working? As far as setup docs go.. I think our powershell scripts for start db servers should use built in windows decompression and set the java home for you (I think when you do it in powershell it sets it only for the current session. Thoughts? |
No. I'm still stuck at this step. |
I also tried using "Node.js Tools for Visual Studio" but ran into some problem with path that were over 260 character long (Visual Studio can't handle that), so that didn't work either. What editor do you use for the UI project? The editing experience of node in Visual Studio is awful, compared to what I'm used to in Visual Studio. |
As much as I hate java (and have two years of java experience) we won't be getting rid of it because elasticsearch is built on top of it :(. I agree with you, that's why we use WebStorm but you could use any text editor like atom. I created a new issue here: exceptionless/Exceptionless.UI#23 for getting started issues. I'd like to meet up with you and get these issues resolved. Also, I've merged your pull request :). |
We will be deploying the fix later today along with another bug fix. |
This fix has been deployed. |
According to the intellisense the parameters on ToExceptionless().SetUserIdentity() should be identity first, and then name, but when looking at the event on exceptionless.io it is the value of the identity parameter that is shown under User Name.
The text was updated successfully, but these errors were encountered: