Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[IR] beatoraja sends the same data when at least one outdated IR jar is loaded #796

Closed
sr8e opened this issue Apr 2, 2024 · 1 comment · Fixed by #810
Closed

[IR] beatoraja sends the same data when at least one outdated IR jar is loaded #796

sr8e opened this issue Apr 2, 2024 · 1 comment · Fixed by #810

Comments

@sr8e
Copy link
Contributor

sr8e commented Apr 2, 2024

version: 0.8.7
IR: minir-5.2.0(outdated), cinnamonIR-0.2.0, mochaIR

beatoraja repeatedly sends the same data of first played chart after launch when at least one outdated IR jar is loaded.
it might be caused by uncaught exception from outdated jar.

最新バージョンに非対応のIRのjarが読み込まれたとき、他の対応しているIRに対しても、起動後最初にプレイした譜面のデータを繰り返し送信するようになる。
恐らく非対応jarが投げる実行時例外のせいだと思います。

@sr8e
Copy link
Contributor Author

sr8e commented Jun 11, 2024

MusicResult.java#L110のforブロック内で例外が出るとcatchに飛んでしまうので送信に成功した分も送信待ちリストから取り除かれないのが原因?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant