-
Notifications
You must be signed in to change notification settings - Fork 146
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade to libgdx 1.11.0 and LWJGL 3.3.1 to fix Mac crash #730
Conversation
@mlaux, hi, how do you compile beatoraja? This breaks the ant build script as dependency file paths haven't been updated there. Did you forget to stage build.xml by any chance? |
I have the exact same thoughts as @staticssleever668 I don't know if it was a good idea to merge this |
I totally agree that proper dependency management like #714 is what is actually needed for the future - my purpose in submitting this change was to give the maintainers a lower-touch option that fixes this particular crash, as well as give passersby that run into this issue a way to fix it for themselves, on their systems, while #714 is discussed and prepared to merge. I definitely intended on making changes to this based on feedback before it was merged (if it was merged at all). I also could have been clearer in my original description. @exch-bms2 can you revert this? Re: the ant issue, I compiled this by creating an IntelliJ project (and honestly didn’t see the build.xml). If we really want to keep this, I’ll make a separate change to fix ant. |
Reverted. |
The problem with the controller not being detected seems to be due to the fact that it is not registered in the mapping managed by the backend, SDL. The actual problem may be simpler or more complex, but in my environment I solved it by generating and registering mappings. There are several ways to register mappings: you can use a mapping string generated by the SDL2 Gamepad Tool or Steam's Big Picture mapping function and append it to However, it would not be realistic for the developer to cover all the controllers that the user might connect, and it is not a good idea to make the user configure complicated settings. There may be some way to do this, as it was previously recognized without doing anything, but it may be unavoidable to maintain the use of the latest libGDX. This is all I have been able to research. I hope this is helpful. PS: The controllers I have tested to work are PHOENIXWAN 2018-2021 models (one generation old). |
This PR also fixes a problem where |
This PR updates the project to libgdx 1.11.0 and LWJGL 3.3.1, fixing a crash on macOS 10.15 and above with certain combinations of JDK and JavaFX versions:
I've played a few songs and graphics, audio, and input all seem to be working correctly. Further testing would be appreciated!