MainLoader : refactor main method #756
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR refactor main method of MainLoader to enhence readability and maintainability.
このPRリファクタは、MainLoaderのメインメソッドで、読み取り可能性とメンテナンス性を高めます
What changed?
check64BitArchitecture: 64bit checkconfigLogger: logger settingparseArgsIntoConfig: parsing args into bmspath and mode variable (args を bmspath およびモードに解析する)isModeConfigured: check BMSPlayerMode variable is configured to PRACTICE, REPLAY ...autotomodecomment
Hello, I am a user who enjoys bms through beatoraja
Thank you for developing the code for users who enjoy bms!
I have interested in beatoraja codes.
So I started to learn about your codes to refactor or enhance program logics.
My code in PR may seem lacking and code smell...
And I maybe misunderstood the code
So If you give me your opinion, I will reflect it.
Thanks!
翻訳機を使って文章がおかしいかもしれませんのでご了承ください
こんにちは。私はbeateraja )を通じてbmsを楽しんでいるユーザーです
BMSを楽しむユーザーのためのコードを開発してくれてありがとう！
私はbeatorajaコードに興味があります。
そこで、プログラムロジックをリファクタリングまたは強化するためのコードについて学び始めました。
私のPRコードが欠けているように見えるかもしれません···
私はコードを誤解しているかもしれません😿
なので、ご意見をいただければ反映させていただきます。
ありがとう！🙏