Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support 0.8.6 IR jars without breaking backwards compatibility #776

Closed
wants to merge 1 commit into from

Conversation

seraxis
Copy link
Contributor

@seraxis seraxis commented Dec 4, 2023

When version 0.8.6 was released it was not mentioned anywhere that this would break compatibility with IR jars from previous versions, resulting in a crash with no feedback as to what went wrong. This adds backwards compatibility for pre-0.8.6 IR jars as nothing has actually changed between the two versions except the method signatures and the inclusion of a wrapper object IR login can try the 0.8.6 login method before softly falling back to the pre-0.8.6 case in MainController without needing to break any existing behaviour.

@SackMagiclight
Copy link
Contributor

Basically, only the latest beatoraja version should be supported; other choices are left to the IR side. In other words, the IR side should be responsible for the implementation associated with it. (I do the same).

This is not a change that should be put into the beatoraja itself.

(deepl)

@seraxis
Copy link
Contributor Author

seraxis commented Dec 6, 2023

I see, thank you for responding, I'd like @exch-bms2 to close this if that's the final decision on the matter

@exch-bms2 exch-bms2 closed this Jul 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants