Adjusted difficulty assignment for bmson files #787
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mainly for bmson files
|
Please remove .DS_Store from PR files. |
I have no idea what I'm doing. Hopefully everything's sorted now
|
Hi, just cleaned up those files. Hopefully everything is sorted now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is a bug in the existing code when it comes to assigning difficulties for bmson files. For instance, if a bmson's title contains the word "Hyper" while the "chart_name" tag (which is parsed as a subtitle) contains "Another", the bmson will be labelled as a Hyper (difficulty 3) chart in-game, and not an Another (difficulty 4). I have adjusted the code to fix that. It will check through only the subtitle/chart_name first, failing which it will go through the existing code loop. I have also added "Leggendaria" as a valid keyword for difficulty 5.