Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating to latest master #4

Merged
merged 15 commits into from May 6, 2021
Merged

Conversation

williamkennedy
Copy link

@williamkennedy williamkennedy commented May 6, 2021

Hey @excid3

I updated the latest jumpstart and noticed some errors, which are fixed in the latest administrate pr found here.

For JSP users they will need to change the following for any manually generated views in the admin.

# from 
    <%= link_to(
      t(
        "administrate.actions.new_resource",
        name: page.resource_name.titleize.downcase
      ),
      [:new, namespace, page.resource_path],
      class: "button",
    ) if valid_action?(:new) && show_action?(:new, new_resource) %>
# to 
    <%= link_to(
      t(
        "administrate.actions.new_resource",
        name: page.resource_name.titleize.downcase
      ),
      [:new, namespace, page.resource_path.to_sym],
      class: "button",
    ) if valid_action?(:new) && show_action?(:new, new_resource) %>

So far, this is just the app/views/admin/pay/subscriptions/index.html.erb in the jsp template

Any questions, let me know.

dependabot-preview bot and others added 15 commits March 19, 2021 16:09
Bumps [rspec-rails](https://github.com/rspec/rspec-rails) from 5.0.0 to 5.0.1.
- [Release notes](https://github.com/rspec/rspec-rails/releases)
- [Changelog](https://github.com/rspec/rspec-rails/blob/main/Changelog.md)
- [Commits](rspec/rspec-rails@v5.0.0...v5.0.1)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>

Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com>
Bumps [webmock](https://github.com/bblimke/webmock) from 3.12.1 to 3.12.2.
- [Release notes](https://github.com/bblimke/webmock/releases)
- [Changelog](https://github.com/bblimke/webmock/blob/master/CHANGELOG.md)
- [Commits](bblimke/webmock@v3.12.1...v3.12.2)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>

Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com>
Bumps [sentry-raven](https://github.com/getsentry/raven-ruby) from 3.1.1 to 3.1.2.
- [Release notes](https://github.com/getsentry/raven-ruby/releases)
- [Commits](getsentry/sentry-ruby@3.1.1...sentry-raven-v3.1.2)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>

Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com>
Bumps [actionview](https://github.com/rails/rails) from 6.1.3 to 6.1.3.1.
- [Release notes](https://github.com/rails/rails/releases)
- [Changelog](https://github.com/rails/rails/blob/v6.1.3.1/actionview/CHANGELOG.md)
- [Commits](rails/rails@v6.1.3...v6.1.3.1)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>

Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com>
For example:

DEPRECATION WARNING: Rendering actions with '.' in the name is deprecated:
fields/time/_index.html.erb (called from block (3 levels) in <top (required
)> at $WORDIR/spec/administrate/views/fields/time/_index_spec.rb:24)
For example:

DEPRECATION WARNING: action_view.raise_on_missing_translations is
deprecated and will be removed in Rails 6.2. Set i18n.raise_on_missing_translations
instead. Note that this new setting also affects how missing translations
are handled in controllers. (called from load at ./bin/rspec:7)
)

When customising your own admin dashboards, it is quite expected to
use consistent graphical elements (such as buttons) in custom pages.

Exposing a `button--alt` CSS class is helpful when adding some custom
buttons, however the existing CSS class includes some spacing
properties which is specific to the navigation bar (because this class
is only used there in the Administrate engine).

This commit moves the spacing property (margin) into a dedicated
`.button--nav` class in order to give the `.button--alt` class a
reusable role.
Bumps [rexml](https://github.com/ruby/rexml) from 3.2.4 to 3.2.5. **This update includes a security fix.**
- [Release notes](https://github.com/ruby/rexml/releases)
- [Changelog](https://github.com/ruby/rexml/blob/master/NEWS.md)
- [Commits](ruby/rexml@v3.2.4...v3.2.5)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>

Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com>
The security updates bumping Rails for 6.1.3.2 and 6.0.3.7 due to a set
of CVEs also meant we needed to switch to using symbols for polymorphic
routes. This commit bumps the version of Rails dependencies to 6.1.3.2
and also switches to using symbols.
Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com>
@williamkennedy williamkennedy changed the title Fetching Upstream Updating to latest master May 6, 2021
@excid3
Copy link
Owner

excid3 commented May 6, 2021

Thanks @williamkennedy 🙏

@excid3 excid3 merged commit d1ba12a into excid3:jumpstart May 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
6 participants