Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Record failing request arguments #305

Closed
wants to merge 2 commits into from
Closed

Record failing request arguments #305

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
30c7975
Adding args to error to gain more insight on failing requests
bvogel Aug 11, 2023
7af3e63
remove puts to clean up logs
bvogel Aug 11, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion lib/noticed.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,9 +33,11 @@ class ValidationError < StandardError

class ResponseUnsuccessful < StandardError
attr_reader :response
attr_reader :args

def initialize(response)
def initialize(response, args = {})
@response = response
@args = args
end
end
end
6 changes: 3 additions & 3 deletions lib/noticed/delivery_methods/base.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,9 +83,9 @@ def post(url, args = {})
end

if !options[:ignore_failure] && !response.status.success?
puts response.status
puts response.body
raise ResponseUnsuccessful.new(response)
logger.warn("failed POST status: #{response.status}")
logger.warn("failed POST response body: #{response.body}")
raise ResponseUnsuccessful.new(response, args)
end

response
Expand Down