iOS Delivery Method Updates and a couple of docs enhancements

[phil-6]

Summary

Functionality

• Changes format to json in lib/noticed/delivery_methods/ios.rb
• Allows json to respond to a symbol as a method in ios.rb
• Allows connection_pool_options to respond to symbol representing a method

Documentation

• Add section about delivery method configuration to README.md
• Add tip about Extracting Delivery Method Configurations to README.md
• Update UPGRADE.md with changes to configuration methods

Description

Changes format to json in lib/noticed/delivery_methods/ios.rb

The UPGRADE.md lists one of the changes being format option for both iOS and FCM being renamed to JSON. This change had only been implemented for FCM. I'm not certain the approach I've taken here is the right one, it might be better to keep the code as-is and revert the change in the docs. It depends what the original intent was.

Allows json to respond to a symbol as a method in ios.rb

This change is lib/noticed/delivery_methods/ios.rb#L36 and adds:

method = event.send(method, apn) if method.is_a?(Symbol) && event.respond_to?(method)

Using the same method as evaluate_options() in the DeliveryMethod class. It evaluates the method if it's a symbol and event responds to that method.

Note: I think a similar change might be needed in fcm.rb, but the execution logic in send_notification(device_token) is different and I can't get it working.

Allows connection_pool_options to respond to symbol representing a method

Similar to the change above, but using the evaluate_options() method to allow extraction of values to methods

Testing

All tests pass.

Checklist

• Code follows the project's coding standards
• Tests have been added or updated to cover the changes
• Documentation has been updated (if applicable)
• All existing tests pass
• Conforms to the contributing guidelines

---

Note: This is my first open source code PR. Happy to take on any and all feedback!