Fixes accessibility aria attributes #171
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
addresses #121
When running lighthouse accessibility scan currently there is an issue with the
[aria-*]
attributes:This PR moves the aria-* attributes from the dropdown controller element to the
buttonTarget
if there is one defined.As mentioned in #121 the developer can/should manually add the
aria-controls
&aria-labelledby
logic,menu
andmenuitem
roles.