Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding the ability for the popover to auto dismiss #182

Merged
merged 2 commits into from
May 15, 2023

Conversation

DmitrySychev
Copy link
Contributor

@DmitrySychev DmitrySychev commented May 14, 2023

Same as with the alerts. Popovers that are triggered by toggle events should have the ability to self dismiss without having to toggle the element again.

src/popover.js Outdated Show resolved Hide resolved
@excid3 excid3 merged commit 7d6bf9e into excid3:master May 15, 2023
2 of 6 checks passed
@excid3
Copy link
Owner

excid3 commented May 15, 2023

Thanks @DmitrySychev 👍

@DmitrySychev
Copy link
Contributor Author

Thanks @DmitrySychev 👍

Thanks, Chris! This project has been very useful.

@excid3
Copy link
Owner

excid3 commented May 15, 2023

Glad it has been! Keep the feature suggestions coming!

@DmitrySychev
Copy link
Contributor Author

DmitrySychev commented May 16, 2023

Ah shoot. I've spent some time debugging this. I didn't update the maps in /dist, so that they'd reflect the code that was added. That means that the js that's being served to the browser is also missing chucks of new code.

I haven't worked with npm and /dist before. Is this something that you could possible assist with?

EDIT - Heya, figured out how to update the maps. Please see - #183

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants