Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change was motivated by a notification in JumpstartRails
the notification is generated when someone makes a comment
I want the notification to redirect to a page - but to show the comments tab
e.g. I started with
when the user clicks on the notification, the link is a get to
/notifications/:id
which redirects to
/resource#comments
this hits two problems:
connect is called while the url is still
/notifications/:id
this is fixed by adding a listener for turbo:load
even then, the hash part is lost
this is fixed by allowing the format
/resource?tab=comments