This repository has been archived by the owner on Feb 26, 2023. It is now read-only.
1235 do not use methodname as action #1236
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
i decided to use |
dodgex
force-pushed
the
1235_do_not_use_methodname_as_action
branch
from
e841bed
to
cb52044
Compare
dodgex
force-pushed
the
1235_do_not_use_methodname_as_action
branch
from
cb52044
to
ad19f91
Compare
dodgex
force-pushed
the
1235_do_not_use_methodname_as_action
branch
from
ad19f91
to
5795a56
Compare
|
You forgot to update the test classes. |
dodgex
force-pushed
the
1235_do_not_use_methodname_as_action
branch
from
5795a56
to
7332ded
Compare
|
the rebase broke the code. its fixed now |
|
Thanks. Will merge to 4.0, but we may have to do several rebases until that, sorry. |
|
no problem. :) |
dodgex
force-pushed
the
1235_do_not_use_methodname_as_action
branch
from
7332ded
to
0cd14d6
Compare
|
Please rebase this PR so it can goo green. |
dodgex
force-pushed
the
1235_do_not_use_methodname_as_action
branch
from
0cd14d6
to
8a24df6
Compare
|
not sure if you got notified about the rebase... so just a smal ping @WonderCsabo :) |
dodgex
force-pushed
the
1235_do_not_use_methodname_as_action
branch
from
8a24df6
to
99e09ed
Compare
|
a damn... i just realized that this PR is for 4.0. you just wanted the rebase to fix the build. /sorry |
|
You do not have to be sorry at all. Thanks for notifying and for the rebase. |
dodgex
force-pushed
the
1235_do_not_use_methodname_as_action
branch
3 times, most recently
from
bc9f7c1
to
a6c227e
Compare
dodgex
force-pushed
the
1235_do_not_use_methodname_as_action
branch
from
a6c227e
to
5f7e365
Compare
dodgex
force-pushed
the
1235_do_not_use_methodname_as_action
branch
from
5f7e365
to
7b69f58
Compare
dodgex
force-pushed
the
1235_do_not_use_methodname_as_action
branch
from
7b69f58
to
d6ef664
Compare
dodgex
force-pushed
the
1235_do_not_use_methodname_as_action
branch
from
d6ef664
to
0919aad
Compare
dodgex
force-pushed
the
1235_do_not_use_methodname_as_action
branch
from
0919aad
to
a04caf8
Compare
dodgex
force-pushed
the
1235_do_not_use_methodname_as_action
branch
2 times, most recently
from
4e4f4a4
to
8df589e
Compare
dodgex
force-pushed
the
1235_do_not_use_methodname_as_action
branch
from
8df589e
to
f9b40c7
Compare
yDelouis
added a commit
that referenced
this pull request
May 24, 2015
…tion 1235 do not use methodname as action
|
Thanks |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
implements issue #1235
based on PR #1234
do not merge before 4.0