Performance improvement on nonblocking sockets #837
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The goal of this change is to further reduce the allocations and system calls for a small number of bytes. By fully consuming the read buffer before reading more bytes, we can avoid making system calls to request less than
max_length
bytes.In order to handle the streaming with a response block cases, I had to add a
block
argument toSocket#read
. This allowed me to denote whether I wanted to wait for bytes to be avialable or not. That together with a newSocket#read_chunk
that tries to read a fullchunk_size
bytes helped me get tests passing.