This moves where it is decided to display the resize handle to the el… #25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ement and out of the resize handle. This is because the resize handle does not re-render when AllowResize changes. This means the ResizeHandle is not shown when you dynamically set AllowResize. It seemed to make more sense to move the display condition than add update handling to the ResizeHandle component.
|
Thanks for this fix! This is now integrated. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ement and out of the resize handle. This is because the resize handle does not re-render when AllowResize changes. This means the ResizeHandle is not shown when you dynamically set AllowResize. It seemed to make more sense to move the display condition than add update handling to the ResizeHandle component.