Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🔀 MERGE: Add inline execution and variable evaluation #414

Merged
merged 13 commits into from
May 5, 2022

Conversation

chrisjsewell
Copy link
Member

No description provided.

`hasHandlers` looks through all parent loggers,
whereas we only want to check handlers specifically on the logger
This commit restructures the execution phase,
to act as a notebook client context manager,
within which the renderer runs.
This will allow for a kernel client to be running during rendering,
and thus for it to be queried for variables.
Make different execution methods subclasses of `NotebookClientBase`
This allows it to work with "inline" execution
@codecov
Copy link

codecov bot commented May 4, 2022

Codecov Report

Merging #414 (57c3a87) into master (4ac8de9) will increase coverage by 0.33%.
The diff coverage is 85.37%.

@@            Coverage Diff             @@
##           master     #414      +/-   ##
==========================================
+ Coverage   80.88%   81.21%   +0.33%     
==========================================
  Files          22       29       +7     
  Lines        2176     2523     +347     
==========================================
+ Hits         1760     2049     +289     
- Misses        416      474      +58     
Flag Coverage Δ
pytests 81.21% <85.37%> (+0.33%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
myst_nb/core/utils.py 82.75% <ø> (ø)
myst_nb/__init__.py 71.42% <50.00%> (ø)
myst_nb/ext/glue/utils.py 59.09% <59.09%> (ø)
myst_nb/core/variables.py 73.33% <73.33%> (ø)
myst_nb/ext/eval/__init__.py 73.72% <73.72%> (ø)
myst_nb/core/execute/__init__.py 78.78% <78.78%> (ø)
myst_nb/core/execute/inline.py 79.62% <79.62%> (ø)
myst_nb/ext/glue/directives.py 68.46% <86.36%> (ø)
myst_nb/core/render.py 84.82% <90.32%> (+1.54%) ⬆️
myst_nb/ext/glue/domain.py 92.30% <92.30%> (ø)
... and 15 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4ac8de9...57c3a87. Read the comment docs.

@chrisjsewell chrisjsewell merged commit 5e2d59c into master May 5, 2022
@chrisjsewell chrisjsewell deleted the inline_exec branch May 5, 2022 01:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant