Add ipywidgets javascript #469
Conversation
|
Thanks for submitting your first pull request! You are awesome! 🤗 |
for more information, see https://pre-commit.ci
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## master #469 +/- ##
=======================================
Coverage 81.47% 81.47%
=======================================
Files 29 29
Lines 2618 2618
=======================================
Hits 2133 2133
Misses 485 485
Flags with carried forward coverage won't be shown. Click here to find out more. Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
|
It is working: https://myst-nb--469.org.readthedocs.build/en/469/render/interactive.html#ipywidgets. Not sure if some default might also need to be updated to account for this, or at least add a note in that section with the config that needs to be set |
|
@OriolAbril thank you for this PR! I am going to close it, because I think we need to fix this slightly differently; at the configuration level. However, we're very glad for people such as yourself making contributions that fix things like this, and your PR prompted me to do so. Cheers! |
|
Actually, we'll still want this to ensure that the docs widgets work with the latest ipywidgets! |
|
Congrats on your first merged pull request in this project! 🎉 |
* Add ipywidgets javascript * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci --------- Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: Angus Hollands <goosey15@gmail.com>
Widgets in the docs stopped rendering in https://myst-nb.readthedocs.io/en/latest/render/interactive.html#ipywidgets. Trying out the fix suggested in #458 to see if it fixes the issue.