Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update readthedocs Config File to fix Test Error #554

Merged
merged 1 commit into from
Oct 16, 2023

Conversation

michaelweinold
Copy link
Contributor

The configuration file

python:
  version: "3.8"

syntax has been deprecated by readthedocs.

Instead,

uild:
  os: ubuntu-22.04
  tools:
    python: "3.11"

has to be used. This would fix test errors caused by the readthedocs build (eg. here: #553).

@welcome
Copy link

welcome bot commented Oct 16, 2023

Thanks for submitting your first pull request! You are awesome! 🤗

If you haven't done so already, check out EBP's Code of Conduct and our Contributing Guide, as this will greatly help the review process.

Welcome to the EBP community! 🎉

@michaelweinold
Copy link
Contributor Author

@choldgraf, the readthedocs build completes successfully. This PR is now ready to merge.

@agoose77 agoose77 self-requested a review October 16, 2023 18:37
@agoose77 agoose77 merged commit 8337278 into executablebooks:master Oct 16, 2023
14 checks passed
@welcome
Copy link

welcome bot commented Oct 16, 2023

Congrats on your first merged pull request in this project! 🎉
congrats

Thank you for contributing, we are very proud of you! ❤️

agoose77 pushed a commit that referenced this pull request Oct 25, 2023
agoose77 added a commit that referenced this pull request Oct 25, 2023
* ci: test wider matrix

* chore: add more Trove classifiers for Python

* ci: fix quoting

* ci: fix interpolation

* ci: test fewer matrix elements

* ci: fix string → array

* ci: simplify matrix further

* ci: even more matrix work

* chore: bump myst-parser for ease

* chore: bump Sphinx version

* ci: fix lower bound

* initial commit (#554)

* [pre-commit.ci] pre-commit autoupdate (#553)

updates:
- [github.com/astral-sh/ruff-pre-commit: v0.0.291 → v0.0.292](astral-sh/ruff-pre-commit@v0.0.291...v0.0.292)
- [github.com/pre-commit/mirrors-mypy: v1.5.1 → v1.6.0](pre-commit/mirrors-mypy@v1.5.1...v1.6.0)

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: Angus Hollands <goosey15@gmail.com>

* [pre-commit.ci] pre-commit autoupdate (#556)

updates:
- [github.com/psf/black: 23.9.1 → 23.10.0](psf/black@23.9.1...23.10.0)
- [github.com/astral-sh/ruff-pre-commit: v0.0.292 → v0.1.1](astral-sh/ruff-pre-commit@v0.0.292...v0.1.1)
- [github.com/pre-commit/mirrors-mypy: v1.6.0 → v1.6.1](pre-commit/mirrors-mypy@v1.6.0...v1.6.1)

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>

* test: update test artefacts

* fix: read UTF-8

* docs: disable `navigation_with_keys`

* trigger RTD build

* docs: disable `navigation_with_keys`

---------

Co-authored-by: Michael Weinold <23102087+michaelweinold@users.noreply.github.com>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants