Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

📚 DOCS: Update API for default parser. #274

Merged
merged 3 commits into from
Dec 18, 2020

Conversation

lesteve
Copy link
Contributor

@lesteve lesteve commented Dec 18, 2020

Fix #247.

Took the code from #247 (comment).

@welcome
Copy link

welcome bot commented Dec 18, 2020

Thanks for submitting your first pull request! You are awesome! 🤗

If you haven't done so already, check out EBP's Code of Conduct and our Contributing Guide, as this will greatly help the review process.

Welcome to the EBP community! 🎉

@codecov
Copy link

codecov bot commented Dec 18, 2020

Codecov Report

Merging #274 (f85ea16) into master (90de3ee) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #274   +/-   ##
=======================================
  Coverage   91.99%   91.99%           
=======================================
  Files          12       12           
  Lines        1399     1399           
=======================================
  Hits         1287     1287           
  Misses        112      112           
Flag Coverage Δ
pytests 91.99% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 90de3ee...f85ea16. Read the comment docs.

@lesteve
Copy link
Contributor Author

lesteve commented Dec 18, 2020

Error is "You must configure the bibtex_bibfiles setting" in https://github.com/executablebooks/MyST-Parser/pull/274/checks?check_run_id=1576032201.

I think this is not related to this PR and is due to the recent release 2.0.0 sphinxcontrib-bibtex.

@chrisjsewell
Copy link
Member

Yep cheers, see mcmtroffaes/sphinxcontrib-bibtex#214, it needs to be pinned to <2.0.0

@chrisjsewell
Copy link
Member

cheers

@chrisjsewell chrisjsewell changed the title Update doc about getting default parser. 📚 DOCS: Update API for default parser. Dec 18, 2020
@chrisjsewell chrisjsewell merged commit ebed2a5 into executablebooks:master Dec 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

parser = default_parser("html") is broken
2 participants