馃憣 IMPROVE: Table rendering #450
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change cell alignment classes to `text-left`, `text-center`, or `text-right`, and allow tables with no body.
Codecov Report
@@ Coverage Diff @@
## master #450 +/- ##
=======================================
Coverage 90.78% 90.79%
=======================================
Files 16 16
Lines 1878 1880 +2
=======================================
+ Hits 1705 1707 +2
Misses 173 173
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
Carreau
pushed a commit
to pydata/pydata-sphinx-theme
that referenced
this pull request
May 27, 2024
This PR makes a few changes to the _tables.scss file: - Matches our table alignment classes with an [update to MyST from 2021](executablebooks/MyST-Parser#450) (version [0.16.0](https://github.com/executablebooks/MyST-Parser/releases/tag/v0.16.0)) - Removes the redundant and useless `display: table` and `overflow: auto` rules - Updates a comment Fixes #1804.
ivanov
pushed a commit
to ivanov/pydata-sphinx-theme
that referenced
this pull request
Jun 5, 2024
This PR makes a few changes to the _tables.scss file: - Matches our table alignment classes with an [update to MyST from 2021](executablebooks/MyST-Parser#450) (version [0.16.0](https://github.com/executablebooks/MyST-Parser/releases/tag/v0.16.0)) - Removes the redundant and useless `display: table` and `overflow: auto` rules - Updates a comment Fixes pydata#1804.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change cell alignment classes to
text-left,text-center, ortext-right,and allow tables with no body.
closes #412, closes #430