-
Notifications
You must be signed in to change notification settings - Fork 190
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add colon syntax for directive options. #50
Conversation
Also add error reporting for YAML block parsing.
self.current_node += [msg_node] | ||
return | ||
# TODO check options are an un-nested dict / json serialize ? | ||
elif content.startswith(":"): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shall we lstrip here and in the while loop? I believe @jstac said he'd imagine indenting the : lines
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
NOW you come in and review, after I removed the review restriction and went ahead and merged this PR 😆 Yeh this makes sense, especially in case the directives are nested, probably also need to handle indentations in the ---
YAML blocks.
If you could add an issue for it or make a new PR ta.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
HAH I knew you were gonna say that ;-)
I'll make it a PR
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
FYI I’ve added #54, so a PR would close that
Also add error reporting for YAML block parsing.