Add colon syntax for directive options. #50
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also add error reporting for YAML block parsing.
This was referenced Feb 18, 2020
Merged
choldgraf
reviewed
Feb 19, 2020
| self.current_node += [msg_node] | ||
| return | ||
| # TODO check options are an un-nested dict / json serialize ? | ||
| elif content.startswith(":"): |
There was a problem hiding this comment.
Shall we lstrip here and in the while loop? I believe @jstac said he'd imagine indenting the : lines
There was a problem hiding this comment.
NOW you come in and review, after I removed the review restriction and went ahead and merged this PR 😆 Yeh this makes sense, especially in case the directives are nested, probably also need to handle indentations in the --- YAML blocks.
If you could add an issue for it or make a new PR ta.
There was a problem hiding this comment.
HAH I knew you were gonna say that ;-)
I'll make it a PR
There was a problem hiding this comment.
FYI I’ve added #54, so a PR would close that
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also add error reporting for YAML block parsing.