Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🔧 Add additional Ruff lints (and fix issues) #862

Merged
merged 10 commits into from Mar 26, 2024

Conversation

danieleades
Copy link
Contributor

lints are in separate commits for ease of reviewing (not every one of these lints will necessarily be of interest)

Copy link

welcome bot commented Jan 26, 2024

Thanks for submitting your first pull request! You are awesome! 🤗

If you haven't done so already, check out EBP's Code of Conduct and our Contributing Guide, as this will greatly help the review process.

Welcome to the EBP community! 🎉

@codecov-commenter
Copy link

codecov-commenter commented Mar 26, 2024

Codecov Report

Attention: Patch coverage is 72.22222% with 5 lines in your changes are missing coverage. Please review.

Project coverage is 90.06%. Comparing base (c3fa3db) to head (8d99f4e).

Files Patch % Lines
myst_parser/parsers/docutils_.py 0.00% 4 Missing ⚠️
myst_parser/mocking.py 50.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           master     #862   +/-   ##
=======================================
  Coverage   90.06%   90.06%           
=======================================
  Files          24       24           
  Lines        3372     3373    +1     
=======================================
+ Hits         3037     3038    +1     
  Misses        335      335           
Flag Coverage Δ
pytests 90.06% <72.22%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Comment on lines +108 to +110
[tool.ruff.per-file-ignores]
"myst_parser/parsers/docutils_.py" = ["FA"]
"myst_parser/config/main.py" = ["FA"]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

there is logic in these files currently utilises runtime analysis of types, so you can't have postponed evaluation

@chrisjsewell chrisjsewell changed the title Add additional Ruff lints 🔧 Add additional Ruff lints (and fix issues) Mar 26, 2024
chrisjsewell
chrisjsewell previously approved these changes Mar 26, 2024
Copy link
Member

@chrisjsewell chrisjsewell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hope you don't mind, but I was impatient and fixed the issues causing your changes to fail CI

@chrisjsewell
Copy link
Member

chrisjsewell commented Mar 26, 2024

@chrisjsewell chrisjsewell merged commit 4e7128c into executablebooks:master Mar 26, 2024
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants