Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

📚 DOCS: Fix admonition example #904

Conversation

72757373656c6c
Copy link
Contributor

Correct admonition example to match class option definition which is a space-separated list.

Add a link to the class option definition for identifier normalization rules.

https://docutils.sourceforge.io/docs/ref/rst/directives.html#identifier-normalization

Correct admonition example to match class option definition
which is a space-separated list.

Add a link to the class option definition for identifier
normalization rules.

https://docutils.sourceforge.io/docs/ref/rst/directives.html#identifier-normalization
Copy link

welcome bot commented Apr 10, 2024

Thanks for submitting your first pull request! You are awesome! 🤗

If you haven't done so already, check out EBP's Code of Conduct and our Contributing Guide, as this will greatly help the review process.

Welcome to the EBP community! 🎉

Copy link
Member

@chrisjsewell chrisjsewell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great thanks!

@chrisjsewell chrisjsewell linked an issue Apr 10, 2024 that may be closed by this pull request
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.07%. Comparing base (10c2003) to head (225b8e7).

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #904   +/-   ##
=======================================
  Coverage   90.07%   90.07%           
=======================================
  Files          24       24           
  Lines        3405     3405           
=======================================
  Hits         3067     3067           
  Misses        338      338           
Flag Coverage Δ
pytests 90.07% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@chrisjsewell chrisjsewell changed the title Fix an admonition example (#902) 📚 DOCS: Fix admonition example Apr 11, 2024
@chrisjsewell chrisjsewell merged commit e830cba into executablebooks:master Apr 11, 2024
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Amonitions class option value: space- or comma-separated list?
3 participants