-
Notifications
You must be signed in to change notification settings - Fork 650
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Navigation breaks if iframe is the last line of a md file #818
Comments
I think I just fixed this in #817 - wanna try this again on master and see if it fixes your problem? |
I'm getting the same result after running |
hmmm I just tried this on the master branch of jupyter book and it looked fine to me. This is what my
is that how yours looked? |
ahhh nevermind, I just saw your point about "newline". OK I can replicate this if there is no blank line on the page |
ok I think that #836 fixes this, wanna upgrade on master and try again? |
yahoo! |
Describe the bug
When an
iframe
is the last line of amd
file, without a trailing new line, some page navigation breaks.To Reproduce
Steps to reproduce the behavior:
jb create jb; cd jb
iframe
to the last line ofintro.md
, e.g.:jb build .
_build/html/intro.html
, which looks like this:Expected behavior
This, which is produced when I add a new line to the end of the file.
Environment (please complete the following information):
jupyter-book --version
:The text was updated successfully, but these errors were encountered: