Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

📚 DOCS: Add web badge #1380

Merged
merged 2 commits into from Jul 20, 2021
Merged

📚 DOCS: Add web badge #1380

merged 2 commits into from Jul 20, 2021

Conversation

choldgraf
Copy link
Member

@choldgraf choldgraf commented Jun 28, 2021

This adds a web badge and some instructions for how others can use it. It uses a base64-encoded image that generated the badge via shields.io

closes executablebooks/meta#156

@codecov
Copy link

codecov bot commented Jun 28, 2021

Codecov Report

Merging #1380 (8bb10b8) into master (28f952d) will decrease coverage by 1.02%.
The diff coverage is n/a.

❗ Current head 8bb10b8 differs from pull request most recent head 1360b37. Consider uploading reports for the commit 1360b37 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1380      +/-   ##
==========================================
- Coverage   91.07%   90.04%   -1.03%     
==========================================
  Files           7        7              
  Lines         672      663       -9     
==========================================
- Hits          612      597      -15     
- Misses         60       66       +6     
Flag Coverage Δ
pytests 90.04% <ø> (-1.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
jupyter_book/cli/pluggable.py 42.42% <0.00%> (-12.13%) ⬇️
jupyter_book/sphinx.py 85.71% <0.00%> (-1.96%) ⬇️
jupyter_book/cli/main.py 94.27% <0.00%> (-0.77%) ⬇️
jupyter_book/config.py 93.52% <0.00%> (ø)
jupyter_book/__init__.py 100.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 28f952d...1360b37. Read the comment docs.

@damianavila
Copy link

There is a misalignment between the logo and the text on the y-axis, IMHO.
But that happens in other places as well, so it is probably an issue to solve in another PR.
LGTM.

damianavila
damianavila previously approved these changes Jun 29, 2021
@choldgraf
Copy link
Member Author

Ya i noticed that too, but wasn't sure how to fix it since we are using shields to generate it 🤔

@choldgraf choldgraf merged commit 4d033ba into executablebooks:master Jul 20, 2021
@choldgraf choldgraf deleted the badge branch July 20, 2021 07:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create a Jupyter Book badge
2 participants