MAINT: Move pypi publish to dedicated workflow #1878
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportBase: 91.39% // Head: 91.39% // No change to project coverage 👍
Additional details and impacted files@@ Coverage Diff @@
## master #1878 +/- ##
=======================================
Coverage 91.39% 91.39%
=======================================
Files 7 7
Lines 686 686
=======================================
Hits 627 627
Misses 59 59
Flags with carried forward coverage won't be shown. Click here to find out more. Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
|
I'm gonna merge this one in so that our PRs stop having an "unfinished" job in them...we'll need to test it out at the time of a release so we might have something to do then but it'll be hard to figure out in this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently we have a workflow embedded in
tests.ymlthat is called only if a new release is made. However this shows us as "not run" in our test suite in github and messes with the passing tests condition.This PR factors that out into a dedicated workflow file that is run on
publishand calls our test suite before running the publish command. That should mean the "Publish to PyPI" action never gets run unless we are publishing.