End pdf playwright

[sammaxwellxyz]

attempting to get this over line #1664

[welcome]

Thanks for submitting your first pull request! You are awesome! 🤗

If you haven't done so already, check out EBP's Code of Conduct and our Contributing Guide, as this will greatly help the review process.

Welcome to the EBP community! 🎉

[codecov]

Codecov Report

Attention: 12 lines in your changes are missing coverage. Please review.

Comparison is base (6b0275a) 91.48% compared to head (8327bb2) 90.11%.
Report is 35 commits behind head on master.

❗ Current head 8327bb2 differs from pull request most recent head 6b8aa58. Consider uploading reports for the commit 6b8aa58 to get more accurate results

Files	Patch %	Lines
jupyter_book/pdf.py	29.41%	12 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #2003      +/-   ##
==========================================
- Coverage   91.48%   90.11%   -1.38%     
==========================================
  Files           7        7              
  Lines         693      698       +5     
==========================================
- Hits          634      629       -5     
- Misses         59       69      +10     

Flag	Coverage Δ
pytests	90.11% <29.41%> (-1.38%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[choldgraf]

Nice - many thanks for breathing life into this. One quick thought: do you think you could add a GitHub action that builds the HTML->PDF version of a book and stores it as a github artifact, so that we can preview what changes would look like?

[sammaxwellxyz]

@choldgraf

Just had a look, and it's already there!

However, based on the size of the artefact (and looking at them) it appears that it may have broken in release 0.14.0

v0.13.2 - https://github.com/executablebooks/jupyter-book/actions/runs/4117887434 - 21.4 MB
v0.14.0 - https://github.com/executablebooks/jupyter-book/actions/runs/4299319674 - 852 KB

I'll take a look at what may have caused it, seems this is the only PR involved in that release #1842.

In another piece of work, I've set a basic file size check as an automatic, if crude, test. Do you think that'd be worth introducing?

[sammaxwellxyz]

closing this as I don't have time to complete, issue already tracked