Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating page layout and hoverable table of contents #278

Merged
merged 3 commits into from
Aug 31, 2019

Conversation

choldgraf
Copy link
Collaborator

@choldgraf choldgraf commented Aug 29, 2019

This PR makes the following large-ish UI changes:

  • The table of contents is now in the topbar, and hidden on narrower screens. Hovering will show it
  • There is now a search bar just to the left of the TOC. No more search in the table of contents
  • There are now popout and full_width classes for special outputs etc.
  • Some tweaks to the timing of widths and when things show/hide etc
  • Performance improvements to the scrolling JS

Main changes

Top navbar + TOC hover:

I8URPjJw53

Page layout features (popout to right, and wide format images)

I7Cpgu8krh

@choldgraf choldgraf force-pushed the toc_hover branch 4 times, most recently from 643b3bf to ba04221 Compare August 29, 2019 21:50
@choldgraf
Copy link
Collaborator Author

choldgraf commented Aug 29, 2019

cc @emdupre lemme know what you think! (great idea about the hovering TOC in the topbar btw)

@choldgraf
Copy link
Collaborator Author

I got a bit of feedback and folks were generally +1 with the idea, so I wanna merge this in and let it simmer in Master before we cut a release. Happy to iterate on improvements to the UI!

@choldgraf choldgraf merged commit 1486218 into jupyter-book:master Aug 31, 2019
@choldgraf choldgraf deleted the toc_hover branch August 31, 2019 01:47
@choldgraf choldgraf added the enhancement New feature or request label Aug 31, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant