🛩👩✈️💺 Remove almost all preflight css #117
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
This nearly looks good to me! I notice a background on the text in the admonition title: Is that unrelated to this PR? The latest PyPI release doesn't seem to show it. |
|
Yeah, I noticed that too. Ok, I am going to spend a bit of time fixing that!! |
|
Fix is here: I think that we merge this one in and fix the other things in the theme, and then can bump the versions and get another release out? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should improve compatibility with other apps in the jupyter ecosystem. There are a few worse things in myst (e.g. icon alignment) but overall this should really cut down on any places that we are interfering with other styles (e.g. in jupyterlab-deck or holoviews).
See #105.
cc @tavin @riziles