Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use selector for JupyterLab dark mode #85

Merged
merged 1 commit into from Feb 15, 2023
Merged

Conversation

agoose77
Copy link
Collaborator

Fixes #67 and fixes #84

@github-actions
Copy link
Contributor

Binder 👈 Launch a Binder on branch executablebooks/jupyterlab-myst/agoose77/fix-dark-mode

@agoose77
Copy link
Collaborator Author

agoose77 commented Feb 15, 2023

We can do more here; JupyterLab defined variables that themes can override. It's a decision as to whether we respect that or not. @rowanc1 the variables that JupyterLab uses are defined here. How confident are you that we can consume these here?

@rowanc1
Copy link
Member

rowanc1 commented Feb 15, 2023

We can override everything in that tailwind config with variables, I have a local branch starting to play with getting styles inline.

For this PR, I think we can keep it to your change, and get better at styles in a next pr!

@agoose77 agoose77 merged commit d266dab into main Feb 15, 2023
@agoose77 agoose77 deleted the agoose77/fix-dark-mode branch February 15, 2023 15:15
@agoose77 agoose77 added the bug Something isn't working label Feb 15, 2023
@mcauthorn
Copy link

Thanks all, after following @agoose77 over here from imarkdown (specifically, your {eval} syntax which is huge feature to our use case), I just ran into this with a custom theme that we're designing for Jupyterlab. A couple of questions:

  1. In my theme config, which variables are read?
  2. Is there a dev branch you could point me to so I could help test?

Thanks again for the activity here, it's looking really promising.

@mcauthorn
Copy link

mcauthorn commented Feb 25, 2023

Found it (it was my config) looking good!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unreadable rendering when using Dark theme Support darkmode
3 participants