Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

馃敡 MAINTAIN: master --> main #3

Merged
merged 4 commits into from
Jul 6, 2021
Merged

馃敡 MAINTAIN: master --> main #3

merged 4 commits into from
Jul 6, 2021

Conversation

rowanc1
Copy link
Member

@rowanc1 rowanc1 commented Jul 6, 2021

Also run prettier on various other files (github workflow and html).

See #4.

@welcome
Copy link

welcome bot commented Jul 6, 2021

Thanks for submitting your first pull request! You are awesome! 馃

If you haven't done so already, check out EBP's Code of Conduct and our Contributing Guide, as this will greatly help the review process.

Welcome to the EBP community! 馃帀

@rowanc1 rowanc1 mentioned this pull request Jul 6, 2021
Copy link
Member Author

@rowanc1 rowanc1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overview of changes.

lint:
runs-on: ubuntu-latest

steps:
- uses: actions/checkout@v2
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No changes other than spaces on these - using the defaults of prettierrc in the repo.

@@ -0,0 +1 @@
tests/fixtures/*.md
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The fixtures are a markdown file which prettier auto corrects, we don't want that.

@@ -1,11 +1,11 @@
<!DOCTYPE html>
<html>
<head>
<meta charset='utf-8'>
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Better html!

Comment on lines -47 to +55
const event = new Event("change");
inputText.dispatchEvent(event);
const event = new Event("change")
inputText.dispatchEvent(event)
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Follow our standards ... ! 馃挜

Comment on lines +39 to +40
"peerDependencies": {
"markdown-it": "12.x"
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was added to the package.json, but no npm install was run.

@chrisjsewell chrisjsewell changed the title 馃憣 IMPROVE: master --> main 馃敡 MAINTAIN: master --> main Jul 6, 2021
@chrisjsewell chrisjsewell merged commit afcc492 into main Jul 6, 2021
@welcome
Copy link

welcome bot commented Jul 6, 2021

Congrats on your first merged pull request in this project! 馃帀
congrats

Thank you for contributing, we are very proud of you! 鉂わ笍

@chrisjsewell chrisjsewell deleted the to-main branch July 6, 2021 07:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants