New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix the more obscure backslash escape tests #8
Comments
For the commonmark spec: Backslash-escapes do not work inside autolinks:
However, we get:
|
👍 not picking this up right now, but I'll leave a comment here if I do later. Do these tests exist in JS markdown-it? Without the |
Yep the test fixtures are copied verbatim from the markdown-it repo: tests/test_port/fixtures, which are all formatted as inputs and expected outputs. You "just" need to remove the skips and fix the code so they pass, without breaking any of the other tests. I've tried before, but gave up after it felt like I was going round in circles lol: fixing one test but making another fail |
I tried it briefly before, but it didn't work. It was harder than I thought it would be. 😭 |
same here! |
I was able to remove one of these skips here #97 admittedly without knowing what I was doing 😄 Hoping that I can trust our tests that I didnt break anything else... |
thanks! yeh the tests are quite comprehensive, including the full commonmark specification. |
These are the final tests that need to be fixed; one that is directly applicable to CommonMark compliance, and the others are for additional compliance with markdown-it. They are all to do with how
\
escapes are treated for some of the more obscure cases in link titles / code fence languages, e.g.[](<\"> "\&\ö")
The text was updated successfully, but these errors were encountered: