Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

♻️ REFACTOR: Port mdurl and punycode for URL normalisation #171

Merged
merged 11 commits into from Dec 1, 2021

Conversation

hukkin
Copy link
Member

@hukkin hukkin commented Jul 20, 2021

Closes #8

@codecov
Copy link

codecov bot commented Jul 20, 2021

Codecov Report

Merging #171 (d025ecb) into master (73763b3) will decrease coverage by 0.00%.
The diff coverage is 83.60%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #171      +/-   ##
==========================================
- Coverage   96.08%   96.08%   -0.01%     
==========================================
  Files          60       61       +1     
  Lines        3248     3273      +25     
==========================================
+ Hits         3121     3145      +24     
- Misses        127      128       +1     
Flag Coverage Δ
pytests 96.08% <83.60%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
markdown_it/_punycode.py 79.31% <79.31%> (ø)
markdown_it/common/normalize_url.py 83.87% <80.00%> (-11.37%) ⬇️
markdown_it/common/utils.py 86.04% <100.00%> (+11.68%) ⬆️
markdown_it/helpers/parse_link_title.py 97.61% <100.00%> (ø)
markdown_it/rules_block/fence.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 73763b3...d025ecb. Read the comment docs.

@hukkin hukkin changed the title FIX: Most URL issues by porting mdurl and punycode FIX: All URL issues by porting mdurl and punycode Jul 20, 2021
@hukkin hukkin marked this pull request as ready for review July 20, 2021 16:10
@chrisjsewell
Copy link
Member

Since https://github.com/hukkin/mdurl would become a core dependency of markdown-it, would it be ok to move this into executablebooks? and you would still be the primary administrator

@hukkin
Copy link
Member Author

hukkin commented Aug 17, 2021

Yeah on the same terms as mdformat I don't see any problem with that.

Note that there's a few TODOs still in mdurl:

  • README.md needs an update
  • One last test file needs to be ported from JS to Python

Any help would be much appreciated!

@hukkin
Copy link
Member Author

hukkin commented Aug 25, 2021

@chrisjsewell I've transferred mdurl to executablebooks.

If you have any extra time, I'd much appreciate a mdit-py release with this and #169 as that would allow me to try fuzzing mdformat again (the last attempt was cut short due to these parser issues 😄 ).

@chrisjsewell chrisjsewell changed the title FIX: All URL issues by porting mdurl and punycode ♻️ REFACTOR: Port mdurl and punycode for URL normalisation Dec 1, 2021
@chrisjsewell chrisjsewell merged commit bb6cf6e into executablebooks:master Dec 1, 2021
@hukkin hukkin deleted the fix-urls branch December 1, 2021 18:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix the more obscure backslash escape tests
2 participants