Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Host documentation on readthedocs.io #72

Closed
3 tasks
hukkin opened this issue Oct 20, 2020 · 5 comments · Fixed by #149
Closed
3 tasks

Host documentation on readthedocs.io #72

hukkin opened this issue Oct 20, 2020 · 5 comments · Fixed by #149
Labels
documentation Improvements or additions to documentation

Comments

@hukkin
Copy link
Member

hukkin commented Oct 20, 2020

  • Create docs with either
    - MkDocs
    - Sphinx + CommonMark or MyST

  • Build the docs in Github Actions.

  • Publish on readthedocs.io

@hukkin hukkin added the documentation Improvements or additions to documentation label Oct 20, 2020
@chrisjsewell
Copy link
Member

Ideally Sphinx + MyST + RTD, the same as the rest of EBP 😬

You don't actually need to run a GH action, just turn on PR runs on RTD:
https://docs.readthedocs.io/en/stable/guides/autobuild-docs-for-pull-requests.html

@hukkin
Copy link
Member Author

hukkin commented Oct 21, 2020

Thanks for the input, I really don't have much experience in any of this.

Sphinx + MyST + RTD sounds great. Or if we want to keep using pre-commit try-repo ... to run mdformat against its own docs, then maybe start with Sphinx + CommonMark and move to MyST, when we can come up with the necessary plugins for mdformat to handle MyST? I kinda like the pre-commit try-repo in that it shows we trust the tool enough to format our own docs with it, and also makes mdformat docs showcase what the output looks like.

You don't actually need to run a GH action, just turn on PR runs on RTD:

Nice! Maybe it's possible to use a GH action to "validate" the docs though? Fail CI if docs fail building, so we know not to merge a PR unless the docs are fixed? Or does Sphinx build ever fail? I'm still a noob here 😄

@chrisjsewell
Copy link
Member

Sphinx + CommonMark and move to MyST

Oh MyST is already commonmark compliant. Its just add extra (optional) syntax plugins to the parser. If you don't use them, then it works exactly the same as CommonMark (we are in fact in talks with RTD to deprectate ReCommonMark in favour of MyST)

Fail CI if docs fail building

Yep this already happens with the RTD builds (you can see the check e.g. in executablebooks/markdown-it-py#58), you just need to add to the repo https://github.com/executablebooks/markdown-it-py/blob/master/.readthedocs.yml

@chrisjsewell
Copy link
Member

chrisjsewell commented Oct 21, 2020

I can try to get round to making a PR for it at some point 😄

@hukkin
Copy link
Member Author

hukkin commented Oct 21, 2020

Its just add extra (optional) syntax plugins to the parser.

Yeah this is what I was thinking could be problematic. But I think you are right, we don't really have to use the extra syntax and if we want to in some files, then skip mdformatting that file etc.

Yep this already happens with the RTD builds

Nice!

I can try to get round to making a PR for it at some point smile

This would be amazing!

@hukkin hukkin mentioned this issue Mar 22, 2021
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants