Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

馃憣 IMPROVE: Use re.sub() instead of re.subn()[0] #58

Merged
merged 2 commits into from
Oct 20, 2020

Conversation

hukkin
Copy link
Member

@hukkin hukkin commented Oct 16, 2020

No description provided.

@codecov
Copy link

codecov bot commented Oct 16, 2020

Codecov Report

Merging #58 into master will not change coverage.
The diff coverage is 85.71%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #58   +/-   ##
=======================================
  Coverage   95.37%   95.37%           
=======================================
  Files          73       73           
  Lines        3571     3571           
=======================================
  Hits         3406     3406           
  Misses        165      165           
Flag Coverage 螖
#pytests 95.37% <85.71%> (酶)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage 螖
markdown_it/common/utils.py 67.44% <50.00%> (酶)
markdown_it/extensions/anchors/index.py 100.00% <100.00%> (酶)
markdown_it/rules_block/table.py 98.51% <100.00%> (酶)
markdown_it/rules_core/normalize.py 100.00% <100.00%> (酶)

Continue to review full report at Codecov.

Legend - Click here to learn more
螖 = absolute <relative> (impact), 酶 = not affected, ? = missing data
Powered by Codecov. Last update 4e1150e...90671c0. Read the comment docs.

@chrisjsewell
Copy link
Member

looks good to me thanks @hukkinj1

@chrisjsewell chrisjsewell changed the title Style: Use re.sub() instead of re.subn()[0] 馃憣 IMPROVE: Use re.sub() instead of re.subn()[0] Oct 20, 2020
@chrisjsewell chrisjsewell merged commit c8f82bc into executablebooks:master Oct 20, 2020
@hukkin hukkin deleted the subn-vs-sub branch October 21, 2020 01:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants