Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use tempfile.gettempdir() as a fallback #384

Closed
wants to merge 1 commit into from

Conversation

guykisel
Copy link

@guykisel guykisel commented Feb 7, 2023

fixes #383

this isn't really the best workaround ever. :(

@welcome
Copy link

welcome bot commented Feb 7, 2023

Thanks for submitting your first pull request! You are awesome! 🤗

If you haven't done so already, check out EBP's Code of Conduct and our Contributing Guide, as this will greatly help the review process.

Welcome to the EBP community! 🎉

@guykisel
Copy link
Author

guykisel commented Feb 7, 2023

the pre-commit.ci run appears to be failing due to some sort of dependency configuration issue. i think it's unrelated to my change?

          × Preparing metadata (pyproject.toml) did not run successfully.
          │ exit code: 1
          ╰─> [17 lines of output]
              Traceback (most recent call last):
                File "/pc/clone/zvRHoZUtS92lKM5aGZlnvA/py_env-python3/lib/python3.11/site-packages/pip/_vendor/pep517/in_process/_in_process.py", line 351, in <module>
                  main()
                File "/pc/clone/zvRHoZUtS92lKM5aGZlnvA/py_env-python3/lib/python3.11/site-packages/pip/_vendor/pep517/in_process/_in_process.py", line 333, in main
                  json_out['return_val'] = hook(**hook_input['kwargs'])
                                           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^
                File "/pc/clone/zvRHoZUtS92lKM5aGZlnvA/py_env-python3/lib/python3.11/site-packages/pip/_vendor/pep517/in_process/_in_process.py", line 152, in prepare_metadata_for_build_wheel
                  return hook(metadata_directory, config_settings)
                         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
                File "/tmp/pip-build-env-fh_0iat7/overlay/lib/python3.11/site-packages/poetry/core/masonry/api.py", line 40, in prepare_metadata_for_build_wheel
                  poetry = Factory().create_poetry(Path(".").resolve(), with_groups=False)
                           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
                File "/tmp/pip-build-env-fh_0iat7/overlay/lib/python3.11/site-packages/poetry/core/factory.py", line 57, in create_poetry
                  raise RuntimeError("The Poetry configuration is invalid:\n" + message)
              RuntimeError: The Poetry configuration is invalid:
                - [extras.pipfile_deprecated_finder.2] 'pip-shims<=0.3.4' does not match '^[a-zA-Z-_.0-9]+$'
                - 

@hukkin hukkin mentioned this pull request Aug 25, 2023
hukkin added a commit that referenced this pull request Aug 25, 2023
Remove atomic writes due to issues users are facing:
- #383 and #384
- #404
- #399
@hukkin
Copy link
Member

hukkin commented Aug 25, 2023

Closing in favor of #409

@hukkin hukkin closed this Aug 25, 2023
@guykisel guykisel deleted the patch-1 branch August 29, 2023 03:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

mdformat._util.atomic_write fails if dir isn't writeable
2 participants