Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dark mode not working #303

Closed
joamatab opened this issue Dec 9, 2023 · 2 comments
Closed

dark mode not working #303

joamatab opened this issue Dec 9, 2023 · 2 comments
Labels
bug Something isn't working

Comments

@joamatab
Copy link

joamatab commented Dec 9, 2023

Describe the bug

context
When I enable dark mode
https://joamatab.github.io/gdsfactory

and i go to another tab on the right , the dark mode disappears

expectation
I expect darkmode to stick as it happens with jupyterbook
https://gdsfactory.github.io/gdsfactory/notebooks/_3_vscode.html

Reproduce the bug

build docs on CICD

https://github.com/joamatab/gdsfactory

List your environment

Jupyter Book      : 0.15.1
External ToC      : 0.3.1
MyST-Parser       : 0.18.1
MyST-NB           : 0.17.2
Sphinx Book Theme : 1.0.1
Jupyter-Cache     : 0.6.1
NbClient          : 0.7.4
@joamatab joamatab added the bug Something isn't working label Dec 9, 2023
Copy link

welcome bot commented Dec 9, 2023

Thanks for opening your first issue here! Engagement like this is essential for open source projects! 🤗

If you haven't done so already, check out EBP's Code of Conduct. Also, please try to follow the issue template as it helps other community members to contribute more effectively.

If your issue is a feature request, others may react to it, to raise its prominence (see Feature Voting).

Welcome to the EBP community! 🎉

@rowanc1
Copy link
Member

rowanc1 commented Mar 11, 2024

Duplicate of #319 and #233. Closing this in favour of discussion in #319.

@rowanc1 rowanc1 closed this as completed Mar 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants