Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dark mode selection does not persist during site navigation #233

Closed
fwkoch opened this issue Sep 11, 2023 · 2 comments
Closed

Dark mode selection does not persist during site navigation #233

fwkoch opened this issue Sep 11, 2023 · 2 comments

Comments

@fwkoch
Copy link
Member

fwkoch commented Sep 11, 2023

Copied from here: executablebooks/mystmd#585

If I activate dark mode on a page, then navigate to another page in the same MyST site, it reverts to light mode. I would expect dark mode selection to persist during site navigation.
@fwkoch fwkoch mentioned this issue Sep 11, 2023
Open
@rowanc1
Copy link
Member

rowanc1 commented Sep 11, 2023

This is broken in static exports, we need to update the dark mode to be based on local preferences rather than server side set cookies.

@rowanc1
Copy link
Member

rowanc1 commented Mar 11, 2024 •
edited

Duplicate of #319 and #303

@rowanc1 rowanc1 marked this as a duplicate of #319 Mar 11, 2024
@rowanc1 rowanc1 closed this as completed Mar 11, 2024
@rowanc1 rowanc1 mentioned this issue Mar 11, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@rowanc1 @fwkoch