Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Page rerenders on scroll #31

Closed
stevejpurves opened this issue Mar 5, 2023 · 2 comments
Closed

Page rerenders on scroll #31

stevejpurves opened this issue Mar 5, 2023 · 2 comments
Labels
bug Something isn't working

Comments

@stevejpurves
Copy link
Contributor

Describe the bug

context
When I do scroll up of down the page.

expectation
I expected React not to re-render the page

bug
But instead rerendering is happening, as confirmed by a console log message in development

problem
This is a problem as this re-rendering is unnecessary and can affect page performance.

Reproduce the bug

  1. run the theme in development
  2. add a console.log message to a page
  3. scroll and watch the console

List your environment

No response

@stevejpurves stevejpurves added the bug Something isn't working label Mar 5, 2023
@welcome
Copy link

welcome bot commented Mar 5, 2023

Thanks for opening your first issue here! Engagement like this is essential for open source projects! 🤗

If you haven't done so already, check out EBP's Code of Conduct. Also, please try to follow the issue template as it helps other community members to contribute more effectively.

If your issue is a feature request, others may react to it, to raise its prominence (see Feature Voting).

Welcome to the EBP community! 🎉

@rowanc1
Copy link
Collaborator

rowanc1 commented Apr 19, 2023

Before:
image

After:
image

rowanc1 added a commit that referenced this issue Apr 19, 2023
rowanc1 added a commit to executablebooks/myst-book-theme that referenced this issue Apr 19, 2023
rowanc1 added a commit to executablebooks/myst-article-theme that referenced this issue Apr 19, 2023
@rowanc1 rowanc1 mentioned this issue Apr 19, 2023
4 tasks
rowanc1 added a commit to executablebooks/myst-book-theme that referenced this issue Apr 19, 2023
rowanc1 added a commit to executablebooks/myst-article-theme that referenced this issue Apr 19, 2023
@rowanc1 rowanc1 closed this as completed Apr 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants