馃暪 Move controls to embed node #142
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rowanc1
commented
Jul 4, 2023
There was a problem hiding this comment.
A few comments @stevejpurves, I think this is complete enough to come in.
| @@ -1,6 +1,7 @@ | |||
| .hover-card-content { | |||
| animation-duration: 0.6s; | |||
| animation-timing-function: cubic-bezier(0.16, 1, 0.3, 1); | |||
| z-index: 10; | |||
There was a problem hiding this comment.
This is the only real style change for z-index.
| {canCompute && article.kind === SourceFileKind.Article && <NotebookToolbar />} | ||
| {/* {canCompute && article.kind === SourceFileKind.Article && <NotebookToolbar />} */} |
There was a problem hiding this comment.
I have commented this out, but we may want to bring something like it back.
There was a problem hiding this comment.
i like the idea of making it figure oriented -- all we are losing here is the ability to "run all" in one go
| import { select } from 'unist-util-select'; | ||
| import { useLinkProvider } from '@myst-theme/providers'; | ||
|
|
||
| function EmbedWithControls({ |
There was a problem hiding this comment.
I have moved the embed -> output node with controls here. This allows us to link to the notebook source.
I am not totally happy with it, but I think it is better than the controls being fully on the right.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This moves the in-article controls to the top of the embed node and also fixes the z-index issues we talked about in #140. I have also removed the article notebook toolbar, I think we could bring it back, but I didn't really think it was necessary? Linked notebooks still work together!