🪐 Launch binder for article theme #239
Conversation
stevejpurves
force-pushed
the
feat/binder-for-articles
branch
from
4dcc6bb
to
f9d7aba
Compare
| const thebe = useThebeOptions(); | ||
| const canCompute = !!thebe && (article.frontmatter as any)?.thebe !== false; | ||
| // TODO in lieu of extended frontmatter or theme options | ||
| const enable_notebook_toolbar = false; |
There was a problem hiding this comment.
@rowanc1 do we have a way of bringing in theme options yet for the web theme? or any thoughts on where to do that?
I am wondering if there is already a mechanism there via the site config + template options?
| @@ -27,7 +27,8 @@ function makeThebeOptions( | |||
| binderBadgeUrl, | |||
| ); | |||
|
|
|||
| const options = thebeFrontmatter ? optionsFromFrontmatter : undefined; | |||
| const options = optionsOverrideFn(thebeFrontmatter ? optionsFromFrontmatter : undefined); | |||
There was a problem hiding this comment.
a parent theme is able to fully manipulate the options, guarding against undesirable options (e..g connecting to a foreign binder) coming in from the myst site, or just being able to patch certain options appropriately for where there parent theme is used/deployed.
|
Confirmed also that from the book-theme when we hit the existing "Launch in Binder" link on the Notebook Toolbar, this successfully opens the jupyterlab on the server. What we are missing in the book-theme experience is a place to add the Launch in Binder link. Should we be considering adding something to the header section of the index article? or some type of top level nav dropdown?
|
|
Couldn't do the rebase well with so many conflicts. The merge I think is correct! We should be sure to squash-merge this when ready. |
thebe/jupytersettingsThis is dependent on recent changes to thebe enabling different "providers" to be configured.