Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

馃帀 Empty frontmatter title should not make H1 #38

Merged
merged 1 commit into from
Mar 20, 2023

Conversation

tavin
Copy link
Contributor

@tavin tavin commented Mar 17, 2023

Fixes a case that may have been uncommon but is more likely when executablebooks/mystmd#281 is done.

@welcome
Copy link

welcome bot commented Mar 17, 2023

Thanks for submitting your first pull request! You are awesome! 馃

If you haven't done so already, check out EBP's Code of Conduct and our Contributing Guide, as this will greatly help the review process.

Welcome to the EBP community! 馃帀

@rowanc1
Copy link
Member

rowanc1 commented Mar 17, 2023

This is awesome @tavin, thanks so much for the various contributions around this!!

I will look at this in my afternoon (in about 4hrs) and get it out!!

@tavin
Copy link
Contributor Author

tavin commented Mar 20, 2023

Cheers @rowanc1 this one should be the least debatable of the PRs I have opened :)

@rowanc1
Copy link
Member

rowanc1 commented Mar 20, 2023

Just working to get back to this, will get to it today!!

@rowanc1
Copy link
Member

rowanc1 commented Mar 20, 2023

Merging this in. :) Thank you.

@rowanc1 rowanc1 merged commit 84c66b9 into executablebooks:main Mar 20, 2023
@welcome
Copy link

welcome bot commented Mar 20, 2023

Congrats on your first merged pull request in this project! 馃帀
congrats

Thank you for contributing, we are very proud of you! 鉂わ笍

@rowanc1 rowanc1 changed the title empty frontmatter title should not make h1 馃帀 Empty frontmatter title should not make H1 Mar 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants