Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

馃惣 Add pandas DataFrame render style #49

Merged
merged 2 commits into from
Apr 19, 2023

Conversation

GYHHAHA
Copy link
Contributor

@GYHHAHA GYHHAHA commented Apr 9, 2023

Now the render result is aligned with sphinx-book-theme. Looks better!

---------------------------------

@stevejpurves
Copy link
Member

@GYHHAHA to understand the context, are you using the myst-theme as-is with book-theme or article-theme or are you developing your own theme?

@GYHHAHA
Copy link
Contributor Author

GYHHAHA commented Apr 18, 2023

@stevejpurves I'm doing my own theme. But these two figures are produced with book-theme by myst-cli.

@rowanc1 rowanc1 changed the title Add pandas DataFrame render style 馃惣 Add pandas DataFrame render style Apr 19, 2023
@rowanc1
Copy link
Member

rowanc1 commented Apr 19, 2023

This looks great! 馃殌 Thank you for your help! :)

@rowanc1 rowanc1 merged commit 7df5b23 into executablebooks:main Apr 19, 2023
1 check passed
@GYHHAHA GYHHAHA deleted the patch-2 branch April 19, 2023 02:13
@stevejpurves
Copy link
Member

stevejpurves commented Apr 19, 2023

ok it's good to get this in and align with the dataframe specific styles from the sphinx theme.

Note that over here: https://github.com/executablebooks/myst-book-theme/pull/4/files we're loading additional stylesheets from thebe which should be in here already really, that will align styling of jupyter outputs to how they are rendered in juptyerlab, and has an impact on the table rendering amongst other things, that will come in with the thebe merge.

image

But those styles are not dataframe specific, they applied to tables outputs generally IIRC.

@GYHHAHA you may want to include those styles in your theme too

@GYHHAHA
Copy link
Contributor Author

GYHHAHA commented Apr 19, 2023

@stevejpurves This is absolutely fine. If thebe style sheet has already decided to control the table render, you can choose to revert my change in jupyter.css in your pr draft. But it's also good to keep this if some users want to make theme themselves and look for some DataFrame render CSS file.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve style effect for DataFrame rendering in React Node with jupyter output
3 participants