📦 Packaging and deployment of the themes #62
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@fperez this fixes an issue that you brought up on the massive bundle that is downloaded for each theme. This PR now is pre-building the templates, and deploying the built artifacts. This means a faster startup time for cloning a template, a faster install of npm packages, and MUCH smaller folder of assets. Now around 30x-35x better than before.
We are shipping a good chunk of Jupyter now with Thebe merged in, so the files aren't tiny for the server, but we are down to <25MB download the first time you get the theme. Better than 800 MB for sure. :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes and follows the process of #61.