馃搫 Update article theme for single project, consume dataUrl #68
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced May 4, 2023
rowanc1
force-pushed
the
feat/single-article
branch
3 times, most recently
from
7966847
to
b59e1a3
Compare
rowanc1
force-pushed
the
feat/single-article
branch
from
b59e1a3
to
c2966d1
Compare
|
Ok, this is tested to work for backwards compatible sites as well as for the next version -- going to merge and deploy the themes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This modifies
article-themeso it is now intended for single-project-to-site configurations. Primarily it removesprojectSlugfrom the url.This also consumes
dataUrlon links/xrefs so source mdast json data can be accessed directly from any provided link (rather than appending.jsonto the source url). This has nice implications around routing the index page for static HTML, i.e. the index page url can be simply/while the mdast is available at/index.json(or something equivalent...). This helps out with executablebooks/mystmd#188