🐛 findExpression allows undefined metadata (#1044)

executablebooks · Apr 2, 2024 · 6a6f445 · 6a6f445
1 parent 855414f
commit 6a6f445
Show file tree

Hide file tree

Showing 3 changed files with 10 additions and 3 deletions.
diff --git a/.changeset/chilly-mice-yell.md b/.changeset/chilly-mice-yell.md
@@ -0,0 +1,5 @@
+---
+"myst-cli": patch
+---
+
+Avoid undefined bug when finding expressions
diff --git a/packages/myst-cli/src/process/notebook.ts b/packages/myst-cli/src/process/notebook.ts
@@ -99,7 +99,9 @@ export async function processNotebook(
         const block = blockParent(cell, cellMdast.children) as GenericNode;
 
         // Embed expression results into expression
-        const userExpressions = block.data?.[metadataSection] as IUserExpressionMetadata[];
+        const userExpressions = block.data?.[metadataSection] as
+          | IUserExpressionMetadata[]
+          | undefined;
         const inlineNodes = selectAll('inlineExpression', block) as InlineExpression[];
         inlineNodes.forEach((inlineExpression) => {
           const data = findExpression(userExpressions, inlineExpression.value);

diff --git a/packages/myst-cli/src/transforms/inlineExpressions.ts b/packages/myst-cli/src/transforms/inlineExpressions.ts
@@ -19,10 +19,10 @@ export interface IUserExpressionsMetadata {
 }
 
 export function findExpression(
-  expressions: IUserExpressionMetadata[],
+  expressions: IUserExpressionMetadata[] | undefined,
   value: string,
 ): IUserExpressionMetadata | undefined {
-  return expressions.find((expr) => expr.expression === value);
+  return expressions?.find((expr) => expr.expression === value);
 }
 
 function processLatex(value: string) {