Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Html to Latex regression 1.1.56 #1161

Closed
dellaert opened this issue Apr 25, 2024 · 7 comments
Closed

Html to Latex regression 1.1.56 #1161

dellaert opened this issue Apr 25, 2024 · 7 comments
Labels
bug Something isn't working

Comments

@dellaert
Copy link

I noticed a regression when upgrading from 1.1.55 to 1.1.56, in that now the HTML output in notebooks no longer renders.

$ myst -v
v1.1.56

Description

myst build --tex now throws these errors whereas in 1.1.55 this worked fine

⛔️ Unhandled LaTeX conversion for node of "div"
⛔️ Unhandled LaTeX conversion for node of "span"

The HTML conversion was put in I think by @rowanc1 to support html output from code in roboticsbook.org, in the conversion to latex. But I guess it broke here :-)

Proposed solution

I'll revert to 1.1.55 for now. I believe @rowanc1 will probably know exactlhy what happened and how to fix.

Additional notes

@dellaert dellaert added the bug Something isn't working label Apr 25, 2024
Copy link

welcome bot commented Apr 25, 2024

Thanks for opening your first issue here! Engagement like this is essential for open source projects! 🤗

If you haven't done so already, check out EBP's Code of Conduct. Also, please try to follow the issue template as it helps other community members to contribute more effectively.

If your issue is a feature request, others may react to it, to raise its prominence (see Feature Voting).

Welcome to the EBP community! 🎉

@dellaert
Copy link
Author

Quick update. Seems that issue already existed in 1.1.55. I had to go back to 1.1.54, and even there I noticed

⛔️ Unhandled LaTeX conversion for node of "span"

but that might have never been supported.

@agoose77
Copy link
Collaborator

@dellaert Rowan will likely know the context of this, but could you share a reproducer so that I might take a look?

@rowanc1
Copy link
Member

rowanc1 commented Apr 25, 2024

We did change the HTML parsing to now preserve divs, but potentially there is something else going on. I will get the latex parsing back up and working with these changes shortly!

@dellaert
Copy link
Author

Thanks @rowanc1
@agoose77 A full repro is hard for me but an example is https://github.com/gtbook/robotics/blob/main/S31_vacuum_state.ipynb. The output of pretty. (Rowan has access to a repo in which the entire book is rendered, which he helped set up).

@rowanc1
Copy link
Member

rowanc1 commented Apr 25, 2024

I will take a look now @dellaert!

@rowanc1
Copy link
Member

rowanc1 commented Apr 25, 2024

This will be released tomorrow!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants