Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Throw error if typst is not available #1013

Merged
merged 3 commits into from Mar 21, 2024

Conversation

agoose77
Copy link
Collaborator

Closes #962

I'm not sure if we have an internal policy for error handling. It seems fine to throw an error, but I'd welcome any feedback if we prefer log-and-return.

@agoose77 agoose77 requested a review from fwkoch March 20, 2024 16:13
@agoose77 agoose77 changed the title fix: throw error if typst is not available 🐛 throw error if typst is not available Mar 20, 2024
@agoose77 agoose77 changed the title 🐛 throw error if typst is not available 🐛 throw error if typst is not available Mar 20, 2024
@agoose77 agoose77 changed the title 🐛 throw error if typst is not available 🐛 Throw error if typst is not available Mar 20, 2024
@agoose77 agoose77 self-assigned this Mar 20, 2024
agoose77 and others added 2 commits March 21, 2024 10:30
Co-authored-by: Rowan Cockett <rowanc1@gmail.com>
@rowanc1 rowanc1 merged commit 8aca668 into main Mar 21, 2024
4 checks passed
@rowanc1 rowanc1 deleted the agoose77/fix-throw-error-typst branch March 21, 2024 17:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Typst export fails silently if typst binary is not available
2 participants