Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

馃悰 findExpression allows undefined metadata #1044

Merged
merged 1 commit into from
Apr 2, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/chilly-mice-yell.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"myst-cli": patch
---

Avoid undefined bug when finding expressions
4 changes: 3 additions & 1 deletion packages/myst-cli/src/process/notebook.ts
Original file line number Diff line number Diff line change
Expand Up @@ -99,7 +99,9 @@ export async function processNotebook(
const block = blockParent(cell, cellMdast.children) as GenericNode;

// Embed expression results into expression
const userExpressions = block.data?.[metadataSection] as IUserExpressionMetadata[];
const userExpressions = block.data?.[metadataSection] as
| IUserExpressionMetadata[]
| undefined;
const inlineNodes = selectAll('inlineExpression', block) as InlineExpression[];
inlineNodes.forEach((inlineExpression) => {
const data = findExpression(userExpressions, inlineExpression.value);
Expand Down
4 changes: 2 additions & 2 deletions packages/myst-cli/src/transforms/inlineExpressions.ts
Original file line number Diff line number Diff line change
Expand Up @@ -19,10 +19,10 @@ export interface IUserExpressionsMetadata {
}

export function findExpression(
expressions: IUserExpressionMetadata[],
expressions: IUserExpressionMetadata[] | undefined,
value: string,
): IUserExpressionMetadata | undefined {
return expressions.find((expr) => expr.expression === value);
return expressions?.find((expr) => expr.expression === value);
}

function processLatex(value: string) {
Expand Down